Break out system inputs vs generic distance for setbacks - #272
Merged
Merged
Conversation
…eric setbacks distance
ppinchuk
added
breaking
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #272 +/- ##
=======================================
Coverage 70.85% 70.86%
=======================================
Files 82 82
Lines 10566 10582 +16
Branches 1224 1228 +4
=======================================
+ Hits 7487 7499 +12
- Misses 2594 2596 +2
- Partials 485 487 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
github-actions Bot
pushed a commit
that referenced
this pull request
May 10, 2026
…_setbacks Break out system inputs vs generic distance for setbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the system height acted as the generic setback distance, which was a bit confusing. To make the experience a little more intuitive for users, we now have separate inputs for the technology parameters (typically height-based values) as well as a generic setback distance inputs. This arguably introduces a little bit of redundancy in the case where you do want to model the generic setback distance as 1x the system height, but in most cases this offers more flexibility than the previous approach while being a little more intuitive for the user.
Thanks again to @gabezuckerman for brainstorming this with me!